Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: imports and vars in 05_go.mdx #1436

Merged
merged 3 commits into from
Jul 4, 2023
Merged

fix: imports and vars in 05_go.mdx #1436

merged 3 commits into from
Jul 4, 2023

Conversation

denispershin
Copy link
Contributor

@denispershin denispershin commented Jun 21, 2023 •
edited
Loading

Fix imports and vars in documentation

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@denispershin
Update 05_go.mdx
94c055f 
Fix imports and vars
@CLAassistant
Copy link

CLAassistant commented Jun 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@denispershin denispershin changed the title Update 05_go.mdx fix: fix imports and vars in 05_go.mdx Jun 21, 2023
@denispershin denispershin changed the title fix: fix imports and vars in 05_go.mdx fix: imports and vars in 05_go.mdx Jun 21, 2023
aeneasr
aeneasr previously approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@vinckr
Copy link
Member

vinckr commented Jun 26, 2023

Thanks for the update!
We usually recommend to use github.com/ory/kratos-go when selfhosting Ory Kratos and github.com/ory/client-go for Ory Network

This would be the equivalent example with client-go: https://www.ory.sh/docs/kratos/sdk/go#create-and-delete-identity

So I would propose to change the SDK back to kratos-client, otherwise great update.
Does this make sense to you as well @aeneasr ?

@denispershin
Copy link
Contributor Author

Thanks for the update! We usually recommend to use github.com/ory/kratos-go when selfhosting Ory Kratos and github.com/ory/client-go for Ory Network

Thank you for review. I fixed imports

@aeneasr aeneasr merged commit 8115fd6 into ory:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

@kmherrmann kmherrmann Awaiting requested review from kmherrmann

@vinckr vinckr Awaiting requested review from vinckr vinckr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denispershin @CLAassistant @vinckr @aeneasr